Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverart tootip if cover is not cached #12087

Merged
merged 5 commits into from Nov 18, 2023

Conversation

daschuer
Copy link
Member

This is on to of #12009 on the way to finally fix #11131

@daschuer
Copy link
Member Author

This should fix the issue on Windows as well, reported here: #12103 (comment)

@daschuer daschuer force-pushed the gh11131_3 branch 2 times, most recently from e19da2c to 53e91c5 Compare November 14, 2023 07:09
@JoergAtGithub
Copy link
Member

In general this works as intended, but I noticed:

  • the delay until the tooltip appears initially (this has always been like this - no regression)
  • this flickering if I hover very slowly over the coverart column in the table (it looks like the tooltip is redrawn at a new position, before the image is fully drawn):
FlickeringCoverArtTooltip.mp4

This is no a change request, but you might have an idea, where this comes from.

@daschuer
Copy link
Member Author

I think you see the stacked cover fetch events they all result in redrawing the tool tip. Can you please test with #12103 which is on top of this. There is a chance that the flickering is fixed with it.

@JoergAtGithub
Copy link
Member

The flickering appears also with #12103

@JoergAtGithub
Copy link
Member

This fixes the issue, that the tooltip is not shown after loading the cover art into the cache. But I noticed other cases when the tooltip is not shown. But these affect also other (text) tooltips, therefore these cases are unrelated.
Code LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 9c8154b into mixxxdj:2.4 Nov 18, 2023
12 checks passed
@daschuer
Copy link
Member Author

Thank you for investigations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants