Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addes the test SoftTakeoverTest.CatchOutOfBounds #12114

Merged
merged 1 commit into from Nov 12, 2023
Merged

Addes the test SoftTakeoverTest.CatchOutOfBounds #12114

merged 1 commit into from Nov 12, 2023

Conversation

daschuer
Copy link
Member

This proves that the slider is able to snap an out of bounds position.
#12011

@daschuer daschuer changed the base branch from main to 2.4 October 15, 2023 05:50
@daschuer daschuer mentioned this pull request Oct 15, 2023
Closed
ronso0
ronso0 requested changes Oct 15, 2023
View reviewed changes
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just typos for now, I'll take a closer look during the next week.

src/test/softtakeover_test.cpp Outdated Show resolved Hide resolved
@daschuer
Copy link
Member Author

Done

ronso0
ronso0 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ronso0 ronso0 merged commit 89c7099 into mixxxdj:2.4 Nov 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronso0 ronso0 ronso0 approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daschuer @ronso0