Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deere: use decks' waveform colors for sliders (Vol + pitch) #12129

Merged
merged 1 commit into from Oct 28, 2023
Merged

Deere: use decks' waveform colors for sliders (Vol + pitch) #12129

merged 1 commit into from Oct 28, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 17, 2023

Closes #10240
image

@github-actions github-actions bot added the skins label Oct 17, 2023
@ronso0 ronso0 mentioned this pull request Oct 17, 2023
Closed
Swiftb0y
Swiftb0y approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes the skin looks a bit gimmicky, but no objection from me. LGTM. Not merging yet to give others a chance to comment too.

@ronso0
Copy link
Member Author

ronso0 commented Oct 17, 2023

makes the skin looks a bit gimmicky

I know, though I feel that's already the case somehow with those rather vibrant waveform (signal) colors (compared to PaleMoon for example).
Hence I think this fits Deere. For LateNight (in case it is ever requested) I'd prefer plain labels (1, 2, ...).

@ronso0
Copy link
Member Author

ronso0 commented Oct 26, 2023

Actually, we could 'easily' turn this into color schemes:

  • Classic:
    • only blue knobs & faders (except purple EQs to distinguish Filter - EQ EQ EQ - Gain)
    • unobtrusive (less saturated) waveform colors
  • Colored:
    • colored knobs & faders
    • vibrant waveform colors

@daschuer
Copy link
Member

Yes, let's go in steps and merge this first.

@daschuer daschuer merged commit d936830 into mixxxdj:2.4 Oct 28, 2023
13 checks passed
@ronso0 ronso0 deleted the deere-slider-colors branch October 28, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
skins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ronso0 @daschuer @Swiftb0y