option to show both elapsed and remaining time simultaneously #1216

Be-ing · 2017-03-13T21:45:44Z

Add a third option for WNumberPos to show both the elapsed and remaining time on a deck. When this is chosen, the format is "elapsed time / remaining time".

…eously

…simultaneously

esbrandt · 2017-03-14T19:24:26Z

src/preferences/dialog/dlgprefcontrolsdlg.ui

@@ -482,6 +482,16 @@
       </attribute>
      </widget>
     </item>
+    <item row="9" column="3">


The introduction of a 3rd column throws off the positioning/aligning of the existing options. Instead, like with the tooltips options, use a horizontal layout for the time display options.

esbrandt · 2017-03-14T19:24:28Z

src/widget/wnumberpos.cpp

+        if (dPosSecondsElapsed >= 0.0) {
+            setText(mixxx::Duration::formatSeconds(
+                        dPosSecondsElapsed, mixxx::Duration::Precision::CENTISECONDS)
+                    % QLatin1String(" / -") %


To me the / separator is unneeded.
Depending on the font, i found it harder to read with it, we already have the -in front of the remaining time display as separator, so 3 spaces and - should do it.

esbrandt · 2017-03-14T19:26:45Z

Thanks for adding a long standing request.
Related https://bugs.launchpad.net/mixxx/+bug/1081456

Edit: track_time tooltip needs update because of the added feature.

The minus sign ("-") before the remaining time is enough.

esbrandt · 2017-03-17T12:41:21Z

LGTM

daschuer · 2017-03-21T09:36:33Z

src/preferences/dialog/dlgprefcontrols.cpp

@@ -70,9 +70,14 @@ DlgPrefControls::DlgPrefControls(QWidget * parent, MixxxMainWindow * mixxx,
    if (!m_pConfig->exists(ConfigKey("[Controls]","PositionDisplay")))
        m_pConfig->set(ConfigKey("[Controls]","PositionDisplay"),ConfigValue(0));

-    if (m_pConfig->getValueString(ConfigKey("[Controls]", "PositionDisplay")).toInt() == 1) {
+    int positionDisplayType = m_pConfig->getValueString(


You can combine this line and the line above by

int positionDisplayType = m_pConfig->getValue(ConfigKey("[Controls]", "PositionDisplay"), 0);

daschuer · 2017-03-21T09:39:01Z

src/preferences/dialog/dlgprefcontrols.cpp

-    if (m_pConfig->getValueString(ConfigKey("[Controls]", "PositionDisplay")).toInt() == 1) {
+    int positionDisplayType = m_pConfig->getValueString(
+            ConfigKey("[Controls]", "PositionDisplay")).toInt();
+    if (positionDisplayType == 1) {
        radioButtonRemaining->setChecked(true);
        m_pControlTrackTimeDisplay->set(1.0);


Please use constexpr for these magic numbers.

I don't understand how a constexpr would help here. Do you mean an enum class?

You cannot convert a enum class to a double without a cast.
The idea was to define
constexpr double k... = 1.0
to get around this.

Everything that replaces the 1.0 by a readable text works for me here, I do not care much about type safety here.
You already use a private enum class inside the widget with the same values. Maybe you find common solution for both.

MK-42 · 2017-03-26T09:30:55Z

Tested on Shade, Deere and LateNight, LGTM

daschuer · 2017-03-26T22:01:29Z

Clang build fails:

In file included from src/preferences/dialog/dlgprefcontrols.cpp:27:
src/preferences/dialog/dlgprefcontrols.h:34:11: error: redefinition of 'Duration' as different kind of symbol
namespace Duration {
          ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/MacTypes.h:286:41: note: previous definition is here
typedef SInt32                          Duration;
                                        ^

build was failing for Mac OS X

Be-ing · 2017-03-27T02:41:04Z

Build fixed on all platforms.

Be-ing · 2017-03-28T18:49:43Z

Ready for merge?

daschuer · 2017-03-28T19:54:39Z

src/preferences/dialog/dlgprefcontrols.cpp

@@ -70,12 +70,23 @@ DlgPrefControls::DlgPrefControls(QWidget * parent, MixxxMainWindow * mixxx,
    if (!m_pConfig->exists(ConfigKey("[Controls]","PositionDisplay")))
        m_pConfig->set(ConfigKey("[Controls]","PositionDisplay"),ConfigValue(0));


Here we should also use the TrackTime::DisplayMode class.
This value does not match the value set in slotResetToDefaults()

This is a common issue whenever someone works on a preferences dialog. Perhaps as part of @Pegasus-RPG's refactoring of the preferences we can come up with a better solution.

daschuer · 2017-03-29T20:01:56Z

Thank you for working on that (and all the other stuff)
LGTM

…apsed and remaining time simultaneously mixxxdj/mixxx#1216

Be-ing added 3 commits March 13, 2017 16:43

add option for WNumberPos to show elapsed and remaining time simultan…

fdce240

…eously

make room in skins for WNumberPos to show elapsed and remaining time …

7841fba

…simultaneously

handle invalid values for WNumberPos display type better

ef92597

esbrandt reviewed Mar 14, 2017

View reviewed changes

Be-ing added 3 commits March 14, 2017 16:25

remove slash ("/") character between elapsed and remaining time

443cb16

The minus sign ("-") before the remaining time is enough.

fix alignment of track time options in preferences

6af3acb

update track_time tooltip for new elapsed + remaining time option

9372b33

daschuer reviewed Mar 21, 2017

View reviewed changes

replace magic numbers with enum class

4f10a72

rename Duration namespace to TrackTime to avoid name collision

50647bb

build was failing for Mac OS X

daschuer reviewed Mar 28, 2017

View reviewed changes

replace magic number with enum class

6eaef2f

daschuer merged commit 23f8a08 into mixxxdj:master Mar 29, 2017

Be-ing deleted the elapsed_and_remaining_time branch March 29, 2017 20:34

esbrandt mentioned this pull request Jun 24, 2017

WIP Manual 2.1.x updates mixxxdj/manual#59

Merged

37 tasks

esbrandt added a commit to esbrandt/manual that referenced this pull request Jun 24, 2017

In the deck section of the user interface, add option to show both el…

fad75f1

…apsed and remaining time simultaneously mixxxdj/mixxx#1216

mixxxbot mentioned this pull request Aug 22, 2022

show both elapsed and remaining time for track in decks #6709

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

option to show both elapsed and remaining time simultaneously #1216

option to show both elapsed and remaining time simultaneously #1216

Be-ing commented Mar 13, 2017

esbrandt Mar 14, 2017

esbrandt Mar 14, 2017

esbrandt commented Mar 14, 2017 •

edited

esbrandt commented Mar 17, 2017

daschuer Mar 21, 2017

daschuer Mar 21, 2017

Be-ing Mar 22, 2017

daschuer Mar 22, 2017

MK-42 commented Mar 26, 2017

daschuer commented Mar 26, 2017

Be-ing commented Mar 27, 2017

Be-ing commented Mar 28, 2017

daschuer Mar 28, 2017

Be-ing Mar 28, 2017

daschuer commented Mar 29, 2017

		@@ -70,12 +70,23 @@ DlgPrefControls::DlgPrefControls(QWidget * parent, MixxxMainWindow * mixxx,
		if (!m_pConfig->exists(ConfigKey("[Controls]","PositionDisplay")))
		m_pConfig->set(ConfigKey("[Controls]","PositionDisplay"),ConfigValue(0));

option to show both elapsed and remaining time simultaneously #1216

option to show both elapsed and remaining time simultaneously #1216

Conversation

Be-ing commented Mar 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

esbrandt commented Mar 14, 2017 • edited

esbrandt commented Mar 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MK-42 commented Mar 26, 2017

daschuer commented Mar 26, 2017

Be-ing commented Mar 27, 2017

Be-ing commented Mar 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daschuer commented Mar 29, 2017

esbrandt commented Mar 14, 2017 •

edited