New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Widget: Recording duration #1220
Conversation
Unfortunately, there does not seem to be a way to let the skin shrink further without causing it to be displayed at that minimum size with a fresh config file.
This reverts commit 78cff2e.
For your current approach, you need to pass the RecordingManager here: Line 332 in 2b26c46
Line 127 in 93bc889
In general, I would prefer a ControlObject based solution passing the unformatted values around and format them at the using element. This would for example also allow to access the values from scripts. |
Thanks for your help! I will try that tonight.
Okay, I see the advantage. Are there plans to use scripts for something other than controllers, skin maybe? |
Move some initialization code into EffectUnit.setCurrentUnit and call setCurrentUnit on construction to ensure that state of show_focus and show_parameters are set correctly when toggling units. Also refactor code for showing/hiding focus controls in skin to a callback connected to show_parameters so it gets triggered by clicking the show_parameters button in skins as well as effectFocusButton on the controller.
…ecordingDuration-Widget
… into RecordingDuration-Widget
… RecordingDuration-Widget
Woohoo, it's working! Can't tell if the code okay, as well. Last recordings duration is visible for a second when new recording is started. Now that I tried it a few times, I think it might be handy to have a all-in-one widget, actually a dynamic button that handles [Recording],toggle_recording, displays [custom_text][recording duration] when recording and would clear when the recording is stopped. Text could be defined with , and , that way the button could be designed for available space or even translated. |
...messed this up with local compile. F#*! |
I'd like to introduce a simple label widget that displays the duration of a running recording in the skin, apart from Recording section in Library.
A while ago I filed a wishlist bug but noone with more C++ experience & spare time picked this up so far.
Newbie that I am, I couldn't make something from the hints @daschuer posted, so I tried to learn from WTime widget (simple widget) and dlgrecording.cpp (queries recordingmanager for recDurationString). Right now I fail to set up the header file correctly.
Is this approach promising at all? If yes, I'd appreciate very much if someone could explain that header file.