Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playlists: simplify import function, add whitespace before the # suffix #12246

Merged
merged 1 commit into from Nov 1, 2023
Merged

Playlists: simplify import function, add whitespace before the # suffix #12246

merged 1 commit into from Nov 1, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 1, 2023

Quick fix for importing playlists with identical name.

Before, import dnb-select.m3u when there already is a playlist named 'dnb-select':

  • dnb-select
  • dnb-select1
  • dnb-select2

Now:

  • dnb-select
  • dnb-select 1
  • dnb-select 2

@ronso0 ronso0 mentioned this pull request Nov 1, 2023
Draft
5 tasks
@JoergAtGithub
Copy link
Member

Much better readability of the code! LGTM! Waiting for CI...

@JoergAtGithub JoergAtGithub merged commit 3df0d6d into mixxxdj:2.4 Nov 1, 2023
13 checks passed
@JoergAtGithub
Copy link
Member

Thank you!

@ronso0 ronso0 deleted the playlist-import-suffix branch November 1, 2023 23:38
@ronso0
Copy link
Member Author

ronso0 commented Nov 1, 2023

Thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronso0 @JoergAtGithub