Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update of play count after removing tracks from history playlist #12258

Merged
merged 2 commits into from Nov 5, 2023
Merged

Fix update of play count after removing tracks from history playlist #12258

merged 2 commits into from Nov 5, 2023

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Nov 4, 2023

@Swiftb0y: Fixes #12046 and #12256.

@fwcd fwcd mentioned this pull request Nov 4, 2023
Closed
Swiftb0y
Swiftb0y reviewed Nov 4, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not well versed in SQL so I would've never spotted this issue during code review. Looking very carefully at your changes, I see how the previous code was buggy and this is fixing it. Thank you. Almost LGTM

tools/mixxxdb_cleanup.sql Show resolved Hide resolved
Swiftb0y
Swiftb0y approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this fix. I doubt this would've gotten fixed by anyone else. LGTM

@Swiftb0y
Copy link
Member

Swiftb0y commented Nov 5, 2023

Waiting for CI, just to be sure.

@Swiftb0y Swiftb0y merged commit 02e5a97 into mixxxdj:2.4 Nov 5, 2023
11 checks passed
@uklotzde uklotzde deleted the remove-from-history-play-count branch November 5, 2023 12:02
@daschuer daschuer added this to the 2.4.0 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
library
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uklotzde @Swiftb0y @daschuer