Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "BaseTrackPlayer: Remove references to WaveformWidgetRenderer when using Qt6" #12342

Merged
merged 1 commit into from Nov 23, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 23, 2023

These constraints were meant for QML while it was coupled to Qt6.

…when using Qt6"

This reverts commit d659a99.

These constraints were meant for QML while it was coupled to Qt6.
@ronso0
Copy link
Member Author

ronso0 commented Nov 23, 2023

Whoops, rebased onto main.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@daschuer daschuer merged commit 2c2e706 into mixxxdj:main Nov 23, 2023
9 of 11 checks passed
@ronso0 ronso0 deleted the revert-qt6-ifdefs branch November 23, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants