Track menu: enable Lock BPM action if any selected track BPM is unlocked #12385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's probably a smarter solution, but it does the job 🤷 |
JoergAtGithub
requested changes
Dec 2, 2023
src/widget/wtrackmenu.cpp
Outdated
Comment on lines
682
to
686
| bool WTrackMenu::isAnyTrackBpmUnlocked() const { | ||
| if (m_pTrackModel) { | ||
| const int column = | ||
| m_pTrackModel->fieldIndex(LIBRARYTABLE_BPM_LOCK); | ||
| for (const auto& trackIndex : m_trackIndexList) { | ||
| QModelIndex bpmLockedIndex = | ||
| trackIndex.sibling(trackIndex.row(), column); | ||
| if (!bpmLockedIndex.data().toBool()) { | ||
| return true; | ||
| } | ||
| } | ||
| } else { | ||
| if (m_pTrack && !m_pTrack->isBpmLocked()) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| bool WTrackMenu::isAnyTrackBpmUnlocked() const { | |
| if (m_pTrackModel) { | |
| const int column = | |
| m_pTrackModel->fieldIndex(LIBRARYTABLE_BPM_LOCK); | |
| for (const auto& trackIndex : m_trackIndexList) { | |
| QModelIndex bpmLockedIndex = | |
| trackIndex.sibling(trackIndex.row(), column); | |
| if (!bpmLockedIndex.data().toBool()) { | |
| return true; | |
| } | |
| } | |
| } else { | |
| if (m_pTrack && !m_pTrack->isBpmLocked()) { | |
| return true; | |
| } | |
| } | |
| return false; | |
| } | |
| void WTrackMenu::accumulateBpmLockStates(bool* anyBpmLocked, bool* anyBpmNotLocked) const { | |
| VERIFY_OR_DEBUG_ASSERT(anyBpmLocked && anyBpmNotLocked) { | |
| return; | |
| } | |
| *anyBpmLocked = false; | |
| *anyBpmNotLocked = false; | |
| if (m_pTrackModel) { | |
| const int column = | |
| m_pTrackModel->fieldIndex(LIBRARYTABLE_BPM_LOCK); | |
| for (const auto& trackIndex : m_trackIndexList) { | |
| QModelIndex bpmLockedIndex = | |
| trackIndex.sibling(trackIndex.row(), column); | |
| if (bpmLockedIndex.data().toBool()) { | |
| *anyBpmLocked = true; | |
| } else { | |
| *anyBpmNotLocked = true; | |
| } | |
| } | |
| } else { | |
| if (m_pTrack) { | |
| if (m_pTrack->isBpmLocked()) { | |
| *anyBpmLocked = true; | |
| } else { | |
| *anyBpmNotLocked = true; | |
| } | |
| } | |
| } | |
| } |
Otherwise it's a lot of code duplication, and this code would be also executed twice.
There was a problem hiding this comment.
Yeah, something like, I was just too lazy last night ; )
Co-authored-by: JoergAtGithub <64457745+JoergAtGithub@users.noreply.github.com>
ronso0
force-pushed
the
trackmenu-fix-unlock-bpm
branch
from
8687782
to
c24cbc1
Compare
JoergAtGithub
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BPM > Lock was not enabled if any of the selected track is locked.