Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/gh12369 beginTimer callback syntax #12401

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Fix/gh12369 beginTimer callback syntax #12401

merged 2 commits into from
Dec 16, 2023

Commits on Dec 5, 2023

  1. feat(pre-commit): only run eslint on changed lines as clang-format 

    This will make it less scaring to make changes to outdated
mappings that are not style-conform.
    @Swiftb0y
    Swiftb0y committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a93beb7 View commit details
    Browse the repository at this point in the history

  2. fix(controller): mass replace outdated usage idioms of `engine.beginT… 

    …imer`

Due to the switch to QJSEngine in Mixxx 2.4 the previous API
where the `this` of the callback function was set to the `this` in the
calling context of the `beginTimer` is not possible to retain
(nor does it make much sense anymore). For this reason this commit
fixes all controllers where this behavior was assumed and updates
the rest of them to use arrow functions instead of anonymous function
expressions or strings.
    @Swiftb0y
    Swiftb0y committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    306bbe4 View commit details
    Browse the repository at this point in the history