Traktor S3: fixes and updates

[ywwg]

Trying to get rid of warnings for this deck

Fixes main vu meter output connections
Update to use non-deprecated makeConnection function
Update hotcue status CO name

[ywwg]

this controller also needs #12406 to work

[JoergAtGithub]

makeConnection has not 4th parameter as connectControl. See

mixxx/res/controllers/engine-api.d.ts

Lines 107 to 116 in bdfb495

	* Connects a specified Mixxx Control with a callback function, which is executed if the value of the control changes
	*
	* This connection has a FIFO buffer - all value change events are processed in serial order.
	*
	* @param group Group of the control e.g. "[Channel1]"
	* @param name Name of the control e.g. "play_indicator"
	* @param callback JS function, which will be called every time, the value of the connected control changes.
	* @returns Returns script connection object on success, otherwise 'undefined''
	*/
	function makeConnection(group: string, name: string, callback: CoCallback): ScriptConnection |undefined;

vs.

mixxx/res/controllers/engine-api.d.ts

Lines 131 to 143 in bdfb495

	/**
	* This function is a legacy version of makeConnection with several alternate
	* ways of invoking it. The callback function can be passed either as a string of
	* JavaScript code that evaluates to a function or an actual JavaScript function.
	*
	* @param group Group of the control e.g. "[Channel1]"
	* @param name Name of the control e.g. "vu_meter"
	* @param callback JS function, which will be called every time, the value of the connected control changes.
	* @param disconnect If "true", all connections to the ControlObject are removed. [default = false]
	* @returns Returns script connection object on success, otherwise 'undefined' or 'false' depending on the error cause.
	* @deprecated Use {@link makeConnection} instead
	*/
	function connectControl(group: string, name: string, callback: CoCallback, disconnect?: boolean): ScriptConnection | boolean | undefined;

[ywwg]

oh that's the difference! I was wondering

[JoergAtGithub]

Same here

[JoergAtGithub]

LGTM! Thank you!