Hercules-DJ-Console-RMX: Replace not defined CO name pitch_reset by pitch_set_default #12441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywwg
reviewed
Dec 18, 2023
| @@ -336,7 +336,7 @@ RMX.define_hid_format = function() { | |||
| c.add_control(pid, "filterHighKill", "[Channel1]", "button", 2, 0x20); | |||
| c.add_control(pid, "filterMidKill", "[Channel1]", "button", 2, 0x40); | |||
| c.add_control(pid, "filterLowKill", "[Channel1]", "button", 2, 0x80); | |||
| c.add_control(pid, "pitch_reset", "[Channel1]", "button", 3, 0x01); | |||
| c.add_control(pid, "pitch_set_default", "[Channel1]", "button", 3, 0x01); | |||
There was a problem hiding this comment.
I think the whitespace has changed too, can you make that consistent?
There was a problem hiding this comment.
Will do - this was pre-commit, not me
There was a problem hiding this comment.
pre-commit insists on the whitespaces (ignore) but it also wants the _unusedVar format.
Do you want to fix that or just carry on and merge?
There was a problem hiding this comment.
Let's just merge it!
JoergAtGithub
force-pushed
the
replace_reset
branch
from
c2e8b16
to
07b9722
Compare
JoergAtGithub
force-pushed
the
replace_reset
branch
from
07b9722
to
15f795c
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported here: https://mixxx.discourse.group/t/hercules-rmx-hid-mapping/14157/48