Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure code signing for windows #12465

Merged
merged 3 commits into from Dec 25, 2023
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Dec 24, 2023

This uses my new Remote Code Signing Certificate on Azure.

The PR has no Access to the Secrets, but my private build works:
https://github.com/daschuer/mixxx/actions/runs/7311877284/job/19921895739

@daschuer daschuer added this to the 2.4.0 milestone Dec 24, 2023
@github-actions github-actions bot added the build label Dec 24, 2023
code-signing-account-name: mixxx
certificate-profile-name: mixxx
files-folder: build
files-folder-filter: dll,exe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixxx.exe is signed, but none of the DLLs (with exception of vcruntime140.dll, which is provided as signed binary by Microsoft).
I'm not sure, if this is neccessary, because my Windows Firewall settings are higly customized.

@@ -345,6 +331,25 @@ jobs:
# Render analyzer waveform tests to an offscreen buffer
QT_QPA_PLATFORM: ${{ matrix.qt_qpa_platform }}

- name: "[Windows] Sign binaries"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: "[Windows] Sign binaries"
- name: "[Windows] Sign executables"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or "executable binaries"

@daschuer
Copy link
Member Author

I have added a code siging PR for the DLLs here: mixxxdj/vcpkg#108

@fwcd
Copy link
Member

fwcd commented Dec 25, 2023

Just a side note, should this target 2.4?

@daschuer daschuer changed the base branch from main to 2.4 December 25, 2023 08:01
@daschuer
Copy link
Member Author

Of cause ... Done

@JoergAtGithub
Copy link
Member

Should we merge this now, or should we wait for the buildenv PR with signed DLLs?

@daschuer
Copy link
Member Author

We can merge this now. There is nothing else to do than switch to the environment for the signed DLLs.
By the way in 2.3 the DLLs are also not signed.

@JoergAtGithub
Copy link
Member

Then let's merge this.
Then we should get Beta builds for Windows again. I'm curious what other user report - because my system is configured in a way, that it never claims about unsigned Mixxx builds.
Thank you!

@JoergAtGithub JoergAtGithub merged commit 8c66d6a into mixxxdj:2.4 Dec 25, 2023
12 checks passed
@ronso0
Copy link
Member

ronso0 commented Dec 25, 2023

Thanks @daschuer fo all this tedious, not very thrilling work on the build system lately!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants