New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure code signing for windows #12465
Conversation
.github/workflows/build.yml
Outdated
code-signing-account-name: mixxx | ||
certificate-profile-name: mixxx | ||
files-folder: build | ||
files-folder-filter: dll,exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixxx.exe is signed, but none of the DLLs (with exception of vcruntime140.dll, which is provided as signed binary by Microsoft).
I'm not sure, if this is neccessary, because my Windows Firewall settings are higly customized.
.github/workflows/build.yml
Outdated
@@ -345,6 +331,25 @@ jobs: | |||
# Render analyzer waveform tests to an offscreen buffer | |||
QT_QPA_PLATFORM: ${{ matrix.qt_qpa_platform }} | |||
|
|||
- name: "[Windows] Sign binaries" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: "[Windows] Sign binaries" | |
- name: "[Windows] Sign executables" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or "executable binaries"
I have added a code siging PR for the DLLs here: mixxxdj/vcpkg#108 |
Just a side note, should this target 2.4? |
Of cause ... Done |
Should we merge this now, or should we wait for the buildenv PR with signed DLLs? |
We can merge this now. There is nothing else to do than switch to the environment for the signed DLLs. |
Then let's merge this. |
Thanks @daschuer fo all this tedious, not very thrilling work on the build system lately! |
This uses my new Remote Code Signing Certificate on Azure.
The PR has no Access to the Secrets, but my private build works:
https://github.com/daschuer/mixxx/actions/runs/7311877284/job/19921895739