Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport Keyboard repeat #11572 to 2.4 #12474

Merged
merged 4 commits into from Jan 12, 2024
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 29, 2023

backport of #11572

ywwg and others added 4 commits December 29, 2023 12:39
…rd key is held.

Fixes mixxxdj#11569

Applies to:
* beats_adjust_faster, beats_adjust_slower
* beats_translate_earlier, beats_translate_later
* beatjump_size_halve, beatjump_size_double
* beatjump_forward, beatjump_backward
* loop_halve, loop_double
* beatjump_X_foward, beatjump_X_backward
* rate_perm_down, rate_perm_down_small, rate_perm_up, rate_perm_up_small
use std::any_of instead of old foreach

Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
@ronso0 ronso0 changed the base branch from main to 2.4 December 29, 2023 12:44
@ronso0 ronso0 added this to the 2.4.0 milestone Jan 3, 2024
Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, though it's partially my own commits :) Happy to require a second approval if you think it's needed.

@daschuer
Copy link
Member

This works like a charm. Thank you.

@daschuer daschuer merged commit ef04ed3 into mixxxdj:2.4 Jan 12, 2024
12 checks passed
@ronso0
Copy link
Member Author

ronso0 commented Jan 12, 2024

Thanks! Credits go to @ywwg

We need a changelog item for this.

@ronso0 ronso0 deleted the keyboard-repeat branch January 12, 2024 10:16
@ronso0 ronso0 added the changelog This PR should be included in the changelog label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog engine keyboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants