fix/History: remove obsolete placeholder playlists #12494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
Jan 2, 2024
| const auto pls = m_playlistDao.getPlaylists(PlaylistDAO::PLHT_UNKNOWN); | ||
| QStringList plsToDelete; | ||
| for (const auto& pl : pls) { | ||
| if (pl.second.startsWith(placeholderName)) { |
There was a problem hiding this comment.
auto above and second here is not well readable.
Not your fault. If you have the mood to improve it go ahead.
Else we can ignore it in this bufix PR
There was a problem hiding this comment.
Yeah, auto was simply faster to type.
I'll change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed I made a mistake in 60198d5 (I had ~300
historyPlaceholder#playlists in my database):the YEAR placeholders are not removed in the destructor because 1) the type is
PlaylistDAO::PLHT_UNKNOWNwhich is not covered bydeleteAllUnlockedPlaylistsWithFewerTracks(), and 2) if it was, they'd be skipped because they are locked.Note: this affects 2.4-beta users only, so we may remove this at some point (2.5?). Otoh the cleanup almost no time after the first execution.