rename PlaylistTableModel::getDurationOfRows(), return mixxx::Duration, add comment #12537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Jan 9, 2024
src/library/playlisttablemodel.h
Outdated
| @@ -27,7 +28,8 @@ class PlaylistTableModel final : public TrackSetTableModel { | |||
| int addTracks(const QModelIndex& index, const QList<QString>& locations) final; | |||
| bool isLocked() final; | |||
|
|
|||
| double getDurationOfRows(const QModelIndexList& indices); | |||
| // Get the total duration of all tracks referenced by the given model indices | |||
There was a problem hiding this comment.
This should be a doc comment starting with ///.
ronso0
force-pushed
the
autodj-duration-fixup
branch
from
8a6ab90
to
69d65d7
Compare
daschuer
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup for #12530