Fix for LoopIn/LoopOut visualisation in waveforms #12538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he playpos is near the end of the loop (or the same for LoopIn, while playing reverse)
|
Adjusting the loop is smooth again. (changes look good but I'm not familiar with the code to approve) |
|
Please test also reverse playing with LoopIn |
Oh, thanks for the reminder! |
ywwg
reviewed
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for not moving the playpos when LoopOut button is hold down and the playpos is near the end of the loop
(or the same for LoopIn, while playing reverse)
Closes: #12506
Closes: #12513
What remains is drawing the loop-markrange end position up to the visualplayposition, instead of the playposition at last enginebuffer processing. I'm not familar with this code.