fix: add multi-sampling settings for QML #12546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2024
acolombier
force-pushed
the
fix/qml-mutli-sampling
branch
2 times, most recently
from
f5924e3
to
d204e9a
Compare
|
@Swiftb0y are you happy with the current solution? |
acolombier
commented
Jan 11, 2024
acolombier
force-pushed
the
fix/qml-mutli-sampling
branch
from
d204e9a
to
2e367bd
Compare
acolombier
force-pushed
the
fix/qml-mutli-sampling
branch
from
2e367bd
to
d829aa8
Compare
Swiftb0y
reviewed
Jan 15, 2024
|
friendly ping @acolombier ;) |
acolombier
force-pushed
the
fix/qml-mutli-sampling
branch
from
d829aa8
to
424385b
Compare
|
Sorry, I missed the notification on that PR @Swiftb0y ! |
Holzhaus
reviewed
Feb 9, 2024
| // Multi-Sampling | ||
| #ifdef MIXXX_USE_QML | ||
| if (CmdlineArgs::Instance().isQml()) { | ||
| mulitSamplingComboBox->clear(); |
There was a problem hiding this comment.
damn... why did CI not catch this?
There was a problem hiding this comment.
Codespell uses a dictionary of common misspellings and does not support camelcase at the moment. The chance that "mulitsamplingcombobox" is in the dict is rather small :)
| const QString kScaleFactorKey = QStringLiteral("ScaleFactor"); | ||
| const QString kStartInFullscreenKey = QStringLiteral("StartInFullscreen"); | ||
| const QString kSchemeKey = QStringLiteral("Scheme"); | ||
| const QString kResizableSkinKey = QStringLiteral("ResizableSkin"); | ||
| const QString kLocaleKey = QStringLiteral("Locale"); | ||
| const QString kTooltipsKey = QStringLiteral("Tooltips"); | ||
| const QString kMultiSamplingKey = QStringLiteral("multi_sampling"); |
There was a problem hiding this comment.
Is there a reason why we don't call it "multi_sampling" instead of "msaa" everywhere? The latter is much less ambiguous IMHO.
|
sorry for the review race-condition... |
my bad, my review came too late xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the work made on #12541 to address #12536 with a customizable multi-sampling level.