Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlayerProxy missing current track when created after loading #12559

Merged

Conversation

acolombier
Copy link
Contributor

This PR fixes the issue where a QMLPlayerProxy is missing the currently loaded track. Currently, if you create a QMLPlayerProxy (or PlayerProxy in QML) while a track is already loaded on a player, the PlayerProxy will appears as if no track was loaded.

This can can be reproduced by

  • Opening the QML interface
  • Load a track on a deck
  • Triggering a reload (e.g touch res/qml/main.qml)

Without this fix, the deck will appears as if empty. With it, and will display correctly, with the loaded track.

@daschuer daschuer added this to the 2.5.0 milestone Jan 14, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 7ab6594 into mixxxdj:main Jan 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants