Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard sheet update #12578

Merged
merged 2 commits into from Jan 15, 2024
Merged

Keyboard sheet update #12578

merged 2 commits into from Jan 15, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 15, 2024

  • add Return: preview load+play / preview stop / track info dialog
  • fix 'rev' (is now back 1beat)
  • update manual links

@ronso0 ronso0 mentioned this pull request Jan 15, 2024
Merged
@daschuer daschuer added this to the 2.4.0 milestone Jan 15, 2024
@daschuer
Copy link
Member

Is this a 2.4 PR?

@ronso0 ronso0 changed the base branch from main to 2.4 January 15, 2024 22:41
@ronso0
Copy link
Member Author

ronso0 commented Jan 15, 2024

Yes, good catch. Changed the base.

daschuer
daschuer approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@daschuer daschuer merged commit 227086b into mixxxdj:2.4 Jan 15, 2024
12 checks passed
@ronso0 ronso0 deleted the keyboard-sheet-update branch January 15, 2024 23:07
@ronso0
Copy link
Member Author

ronso0 commented Jan 15, 2024

Thanks, that was quick!

Oh, and one thing to keep in mind @mixxxdj/developers:
when the mapping SVG was touched and saved as "Optimized SVG", double-check all layers are still there.
IIUC that may discard layers which makes the export workflow (for the manual)... much less fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronso0 @daschuer