Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(waveforms): add missing precision specifier to repetions uniform of patternshader #12607

Merged

Conversation

Swiftb0y
Copy link
Member

fixes #12600

don't have a windows env so I can't confirm the original bug nor confirm this fixes it, but I'm fairly certain it should. please test @JoergAtGithub ty.

@Swiftb0y Swiftb0y force-pushed the fix/gh12600-angle-opengl-no-precision branch from 5831b9d to 329f2b3 Compare January 21, 2024 14:46
@Swiftb0y
Copy link
Member Author

fyi not sure if that actually fixes the issue itself (it seems rather weird), but it should fix the error messages you posted.

@JoergAtGithub
Copy link
Member

I can confirm, that this fixes the error message. But not the resizing issue. Thank you!

@JoergAtGithub JoergAtGithub merged commit 1483d43 into mixxxdj:2.4 Jan 21, 2024
13 checks passed
@Swiftb0y
Copy link
Member Author

Thanks for testing and merging

@Swiftb0y Swiftb0y deleted the fix/gh12600-angle-opengl-no-precision branch January 21, 2024 16:46
@daschuer daschuer added this to the 2.4.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants