Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins: add loop cue icons #12632

Merged
merged 4 commits into from Jan 23, 2024
Merged

Skins: add loop cue icons #12632

merged 4 commits into from Jan 23, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 23, 2024

LateNight classic
Not ideal but there'a clear distinction between hotcues and loop cues.
image image

Deere
image

Tango
image
Since bg icons are scaled (down) it looks non-ideal in samplers and squeezed decks, but better than nothing
image image
Re squeezed decks: I'll open a PR to increase Tango's minimum size. With most configurations it'll still fit into 1024px screens but at least we don't get complaints it looks bad when we still claim to support 1024px.

Shade
I ave no patience to fiddle with the PNGs, I just added a WIP GiMP template.
If someone wants to finish that:

  • move hotcue icons from <State> nodes in xml to style sheets
    WHotCueButton[displayValue="0"] for empty state
    WHotCueButton[displayValue="1"], WHotCueButton[displayValue="2"] for loaded and 'active' state, add hotcue icons per hotcue number
  • add WHotCueButton[displayValue="1"][type="loop], WHotCueButton[displayValue="2"][type="loop] selectors, add loop cue icons per hotcue number

@github-actions github-actions bot added the skins label Jan 23, 2024
@ronso0 ronso0 added this to the 2.4.0 milestone Jan 23, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works good. Thank you.
I will take a look at Shade.

@daschuer daschuer merged commit 665325d into mixxxdj:2.4 Jan 23, 2024
13 checks passed
@ronso0 ronso0 deleted the skins-loopcue-icons branch January 23, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.4 update Hotcue buttons with 'Loop cue' icon in Deere, Tango and Shade
2 participants