Engine: Add feature for building with/without Rubberband #12661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
force-pushed
the
rubberband-feature
branch
from
0ffd67f
to
6d46b0e
Compare
fwcd
force-pushed
the
rubberband-feature
branch
from
6d46b0e
to
3889db7
Compare
fwcd
force-pushed
the
rubberband-feature
branch
from
3889db7
to
d8834e5
Compare
fwcd
force-pushed
the
rubberband-feature
branch
from
d8834e5
to
be02a20
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to build Mixxx without Rubberband, using SoundTouch as the default keylock engine instead. This has proven pretty useful in building Mixxx for iOS, both for technical reasons (cross-compiling the library seems to be non-trivial) and potential licensing reasons (non-App-Store-clause-GPL).