Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionStore: Make iOS a recognized platform #12665

Merged
merged 3 commits into from Jan 28, 2024
Merged

VersionStore: Make iOS a recognized platform #12665

merged 3 commits into from Jan 28, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jan 28, 2024

A small "risk-free" patch towards iOS support

@fwcd fwcd mentioned this pull request Jan 28, 2024
Open
48 tasks
@fwcd fwcd added the ios label Jan 28, 2024
@JoergAtGithub
Copy link
Member

AFAIK, xwax which we use for vinyl control has no App Store Clause too.

@fwcd
Copy link
Member Author

fwcd commented Jan 28, 2024

Good point, though the library stuff is coming later.

JoergAtGithub
JoergAtGithub approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Waiting for CI.

@daschuer
Copy link
Member

By the way, did you use a special iOS vcpkg? Is it possible to crosscompile for the "arm64-ios" triplet on a x64 macOS?

daschuer
daschuer approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Green. Thank you.

@daschuer daschuer merged commit 4fcf676 into mixxxdj:2.4 Jan 28, 2024
14 checks passed
@fwcd fwcd deleted the versionstore-ios branch January 28, 2024 15:16
@fwcd
Copy link
Member Author

fwcd commented Jan 28, 2024 •
edited

By the way, did you use a special iOS vcpkg? Is it possible to crosscompile for the "arm64-ios" triplet on a x64 macOS?

Probably, I've crosscompiled from arm64-osx and most stuff built as-is, but there are still some packages I had to patch (most was minor stuff, like a GL ES 3.0 flag in qtbase, the largest one is probably a patch adding iOS support to PortAudio, not sure what the upstream status of that is). Details are here: fwcd/m1xxx#16, this is my vcpkg branch: https://github.com/fwcd/vcpkg/tree/mixxx/ios-qt6

@JoergAtGithub
Copy link
Member

The review and development cycles of https://github.com/PortAudio/portaudio/ are very long. I recommend to open a PR as early as possible, to ensure, that it's available, when we need it.

@fwcd
Copy link
Member Author

fwcd commented Jan 29, 2024

Done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@JoergAtGithub JoergAtGithub JoergAtGithub approved these changes

Assignees
No one assigned
Labels
ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwcd @JoergAtGithub @daschuer