Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DesktopHelper: Cond-compile out process creation on iOS #12674

Merged
merged 1 commit into from Jan 29, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jan 28, 2024

Forking is not supported on iOS, so we'll emit a warning instead.

@fwcd fwcd added the ios label Jan 28, 2024
@fwcd fwcd mentioned this pull request Jan 28, 2024
48 tasks
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this feature ever of showing a file in "finder" ever be available? What is equivalent for the use case? Or can we remove the feature entirely on iOS?

@fwcd
Copy link
Member Author

fwcd commented Jan 29, 2024

I'm not sure what the precise API is, but I think there might be a way to deep link into the iOS files app (the native file browser on iOS, which only presents a small view of the file system, namely the user's documents and app sandboxes).

Edit: Looks like shareddocuments://<path to file> URIs might be able to do that:

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit acf8e47 into mixxxdj:2.4 Jan 29, 2024
14 checks passed
@fwcd fwcd deleted the cond-compile-process-ios branch January 30, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants