Sandbox: Add basic iOS support #12675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
force-pushed
the
sandbox-ios
branch
2 times, most recently
from
502a4c9
to
812873a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the cond-compiles (e.g. the
Securityheaders are unavailable on iOS) and then adds basic support for sandboxing on iOS.I am not sure if the implementation entirely works as intended (the bookmark part is from this Qt bug), since the iOS sandbox is a fair bit more restrictive compared to macOS, especially concerning bookmark creation. IIUC, we would need some special logic to store URLs returned by a file picker and call
startAccessingSecurityScopedResourceetc., though even then we likely cannot persist this temporary permission like on macOS and may have to resort to copying the file into a sandbox directory or similar.In any case, it shouldn't hurt to already have this logic in place to make it compile and, if needed, we can always update it later (the worst that would currently happen is spamming the user with too many sandbox popups since the OS may not give the right permission for anything outside the app's sandbox).