Adjust the taglib1 lookup path for archlinux

[daschuer]

No description provided.

[mxmilkiib]

I'm getting;

-- CMAKE_VERSION: 3.28.3
-- Optimization level: native
Enabling native optimizations for x86_64
-- Found ccache: /usr/bin/ccache
-- Support for ccache: ON
-- Found ld.lld with version: 16.0.6
-- Selecting lld as linker
-- Enabling QML Debugging! This poses a security risk as Mixxx will open a TCP port for debugging
-- Could NOT find DjInterop (missing: DjInterop_DIR)
-- Could NOT find DjInterop (missing: DjInterop_LIBRARY DjInterop_INCLUDE_DIR DjInterop_VERSION) (Required is exact version "0.20.1")
-- Building libdjinterop sources (with system SQLite) fetched from GitHub
-- Could NOT find KeyFinder (missing: KeyFinder_LIBRARY KeyFinder_INCLUDE_DIR) (Required is at least version "2.2.4")
CMake Error at CMakeLists.txt:2944 (message):
  Installed Taglib 2.0 is not supported.  Use Version >= 1.11 and < 2.0 and
  its development headers.


-- Configuring incomplete, errors occurred!

linkback #12708 #12760

[daschuer]

Strange, the arch mixxx package now includes basically the same patch:
https://gitlab.archlinux.org/archlinux/packaging/packages/mixxx/-/blob/main/PKGBUILD?ref_type=heads#L84

I am not on arch so I cannot test. Who is able to share some insights?

[mxmilkiib]

mixxx/build taglib1 ± cmake -DCMAKE_INSTALL_PREFIX=/usr -DINSTALL_USER_UDEV_RULES=OFF -DOPTIMIZE=native -DQT6=OFF -DBULK=ON -DFAAD=ON -DLILV=ON -DFFMPEG=ON -DKEYFINDER=ON -DMAD=ON -DMODPLUG=ON -DOPUS=ON -DQTKEYCHAIN=ON -DWAVPACK=ON -DCMAKE_BUILD_TYPE=Debug -DDEBUG_ASSERTIONS_FATAL=ON ..

gives

...
CMake Error at CMakeLists.txt:2944 (message):
  Installed Taglib 2.0 is not supported.  Use Version >= 1.11 and < 2.0 and
  its development headers.

Edit: N.b. I see this PR branch is based off of 2.4 not 2.5, as it failed when I tried turning QT6 ON.

[toszlanyi]

this PR builds fine for me on EndeavourOS with taglib2 and taglib1 installed side by side.

refs/pull/12892/head -> taglib1
Zu Branch 'taglib1' gewechselt

[osz@osz-Yoga7 mixxx]$ cd build
[osz@osz-Yoga7 build]$ cmake ..
...
-- Found TagLib: /usr/lib/taglib1/libtag.so (found suitable version "1.13.1", minimum required is "1.11") 
...
[osz@osz-Yoga7 build]$ cmake --build . -j16
...
[100%] Linking CXX executable mixxx-test
[100%] Built target mixxx-test
[osz@osz-Yoga7 build]$

[daschuer]

Thank you @toszlanyi
Can one take care and merge this?

@mxmilkiib after merging this to 2.4 I will merge 2.4 to main. Than we can look loser to your issue. Hopefully it will have vanished then.

[daschuer]

@JoergAtGithub can you have a final look and merge this?

[JoergAtGithub]

Since it's only a path change and a user reported, that it works now, I think it's correct. Thank you!