Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Emit better errors for exotic target platforms #12910

Merged
merged 1 commit into from Mar 4, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 3, 2024

Currently, users will get a slightly misleading error message e.g. when referring to the macOS environment when building for "exotic" platforms like iOS or Debian when targeting Emscripten (WebAssembly).

This fixes the issue by only suggesting the prebuilt environments when targeting the corresponding platforms and referring the user to vcpkg otherwise.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit e8087ee into mixxxdj:main Mar 4, 2024
13 checks passed
@fwcd fwcd deleted the better-no-env-errors branch March 4, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants