Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add PORTMIDI flag for compiling with(out) PortMidi #12913

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 4, 2024

This is consistent with the other controller backends and will be useful both for targeting Emscripten/WebAssembly (since PortMidi doesn't support Web MIDI yet) and for a potential libremidi migration in the future.

@fwcd fwcd added the wasm label Mar 4, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 52c8c0e into mixxxdj:main Mar 4, 2024
13 checks passed
@fwcd fwcd deleted the portmidi-flag branch March 4, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants