(fix) TrackModel remove tracks #12927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids hitting DEBUG_ASSERT when removing tracks from a locked crate
ronso0
force-pushed
the
trackmodel-remove-tracks-fix
branch
from
98d4b5b
to
99c0a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding track menu action is disabled but it was still possible via hotkey.
Added a
isLocked()to the crate model to avoid running into a debug assert.When merging this please also merge 2.4 to main so we can rebase https://github.com/mixxxdj/mixxx/tree/tracklists_shortkeys asap.