Show hint if resource path in CMakeCache.txt does not exist #12929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this change makes sense to improve developer experience, I'm afraid it could be be misleading if a final user is seeing this (e.g after accidentally moving/removing is Perhaps a solution would be to add a CMake definition (ON by default OFF when building production artefacts) and give different message depending that definition. @mixxxdj/developer any objection? |
|
Another solution would be to make the message conditional for the different sources of the res path. |
daschuer
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
CMakeCache.txtwas located in the same directory as themixxxbinary,mixxxtried to read the resource path from theCMakeCache.txtfile. However, if the resource path is not available, is simply prints an error and exits the application. Now a hint is displayed stating to use the command line option--resource-path <path>.Additionally, this error is suppressed when a user requests help on command line options with
--help.