CMakeLists: Require WebGL 2.0 when building for Wasm #12952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need GL ES 3.0 and by requiring a WebGL 2 browser, we can reduce the
size of the binary.
Note that we need -sFULL_ES2=1 to avoid warnings like
WebGL: INVALID_OPERATION: vertexAttribPointer:
no ARRAY_BUFFER is bound and offset is non-zero
We also need to make these link options public.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need OpenGL ES 3.0 and by requiring a WebGL 2 browser, we can reduce the size of the binary.
We also need
-sFULL_ES2=1to avoid warnings like...and the link options have to be public to apply to the final binary.