Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindSndFile: Link FLAC in static builds #13085

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Apr 10, 2024

This should fix some linker errors in static builds on Linux (before vs. after):

/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux-release/lib/libsndfile.a(flac.c.o): in function `flac_close':
flac.c:(.text+0x958): undefined reference to `FLAC__metadata_object_delete'
/usr/bin/ld: flac.c:(.text+0x9d6): undefined reference to `FLAC__stream_encoder_finish'
/usr/bin/ld: flac.c:(.text+0x9e0): undefined reference to `FLAC__stream_encoder_delete'
/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux-release/lib/libsndfile.a(flac.c.o): in function `flac_write_header':
flac.c:(.text+0xd37): undefined reference to `FLAC__metadata_object_vorbiscomment_entry_from_name_value_pair'
/usr/bin/ld: flac.c:(.text+0xd4a): undefined reference to `FLAC__metadata_object_vorbiscomment_append_comment'
/usr/bin/ld: flac.c:(.text+0xd65): undefined reference to `FLAC__stream_encoder_set_metadata'
/usr/bin/ld: flac.c:(.text+0xd91): undefined reference to `FLAC__stream_encoder_init_stream'
/usr/bin/ld: flac.c:(.text+0xec7): undefined reference to `FLAC__StreamEncoderInitStatusString'
/usr/bin/ld: flac.c:(.text+0xef2): undefined reference to `FLAC__metadata_object_new'
/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux-release/lib/libsndfile.a(flac.c.o): in function `sf_flac_meta_callback':
flac.c:(.text+0x10ac): undefined reference to `FLAC__metadata_object_vorbiscomment_find_entry_from'
/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux-release/lib/libsndfile.a(flac.c.o): in function `flac_enc_init':
flac.c:(.text+0x1d50): undefined reference to `FLAC__stream_encoder_delete'
/usr/bin/ld: flac.c:(.text+0x1d55): undefined reference to `FLAC__stream_encoder_new'
/usr/bin/ld: flac.c:(.text+0x1d70): undefined reference to `FLAC__stream_encoder_set_channels'
/usr/bin/ld: flac.c:(.text+0x1d83): undefined reference to `FLAC__stream_encoder_set_sample_rate'
/usr/bin/ld: flac.c:(.text+0x1d97): undefined reference to `FLAC__stream_encoder_set_bits_per_sample'
/usr/bin/ld: flac.c:(.text+0x1dae): undefined reference to `FLAC__stream_encoder_set_compression_level'

@fwcd fwcd marked this pull request as ready for review April 10, 2024 21:59
@daschuer daschuer merged commit 2c75eb8 into mixxxdj:main Apr 21, 2024
13 checks passed
@fwcd fwcd deleted the link-flac-sndfile branch April 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants