Initial DB tests for CrateStorage #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
suggested changes
Jul 10, 2017
src/test/cratestorage_test.cpp
Outdated
| ASSERT_TRUE(crateId.isValid()); | ||
| } | ||
|
|
||
| // Find crate by id |
There was a problem hiding this comment.
It would be helpful to clarify this comment a little: "Find the same crate as above, this time by ID instead of name"
src/test/cratestorage_test.cpp
Outdated
|
|
||
| // Update crate name | ||
| const auto kNewCrateName = QString("New%1").arg(kCrateName); | ||
| Crate crateUpdated = crateById; |
There was a problem hiding this comment.
Why create a new Crate variable here? I think the intention would be clearer by reusing crateById
There was a problem hiding this comment.
Nope. During each step a new, empty crate object should be populated directly from the database. Otherwise you can not be sure if it got its values from the previous read operation.
Ideally the test would be split up into smaller tests, each with a special purpose. But here it was convenient to cover the whole lifecycle by a single test.
|
Thank you! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a simple test for CrateStorage, we did'nt have one yet 馃檲 Maybe also helpful for @gramanas how to test the new code for crate hierarchy at the persistent layer.