Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pioneer DDJ-REV1 mappings #13109

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

LauraRozier
Copy link

Controller mappings for the Pioneer DDJ-REV1

Skipped features (don't exist within Mixxx):

  • TrackingScratch Mode Pads
  • Trans Mode Pads
  • ScratchBank Mode Pads

Still a draft while I test things and work out some quirks / docs

@JoergAtGithub
Copy link
Member

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@JoergAtGithub
Copy link
Member

The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system, as described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking
Than it will fix these issues automatically before every commit.
Alternatively, you can download the pre-commit.patch file from the artifacts of this PR
grafik
unzip it, and apply it using:
git apply pre-commit.patch

@LauraRozier
Copy link
Author

LauraRozier commented Apr 17, 2024

Yep, that's why it's in DRAFT mode. ^_^ Work in progress, so builds will fail.
Did the 'ol contributor agreement thing just now as well.

As for documenting the whole shebang for the manual.. That might take some time.. ^_^"
I'm fast with things I enjoy working on, but hella slow with docs.

Currently I'm experiencing some troubles getting the FX buttons to light up properly, this looks like an issue with the controller itself, rather than Mixxx's mapping. When pressing the FX button it lights up, then immediately goes off again, even though the effect stays on in Mixxx, from that point forwards the button acts inverted. It's weird..
I'm talking about buttons 3,4,5 in the image below
image

EDIT: They do work correctly when toggled within Mixxx itself. They only miss-behave when using them on the controller itself. If anyone has any ideas, feel free to suggest. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants