Skins: Add a <NumberDuration> control for skins #13176
Conversation
Although the WNumberPos has a similar purpose, it is tailored strictly for displaying the play position of a deck. The WTime control is also similar, but only displays the current time.
cr7pt0gr4ph7
changed the title
cr7pt0gr4ph7
force-pushed
the
add-wnumberduration-control
branch
from
e82e2c8
to
7243e05
Compare
|
|
||
| class ControlProxy; | ||
|
|
||
| class WNumberDuration : public WNumber { |
There was a problem hiding this comment.
Could you please add some doc-string to document what this component is used for?
| m_displayFormat = TrackTime::DisplayFormat::TRADITIONAL; | ||
| } else if (formatString == "traditional_coarse") { | ||
| m_displayFormat = TrackTime::DisplayFormat::TRADITIONAL_COARSE; | ||
| } else { |
There was a problem hiding this comment.
You might want to use SKIN_WARNING macro to alert of a potentially unsupported format. I understand that TimeFormat may be an arbitrary string passed to QTime::toString. Perhaps you could use two attributes (e.g TimeFormat is an enum, including custom and CustomFormat allow you to define the arbitrary string, stored in m_displayFormatString. This way, it will help debugging cases where user accidentally mistype a pre-constructed enum.
There was a problem hiding this comment.
How about two properties PredefinedFormat (or StandardFormat/DefaultFormat) and CustomFormat)? And just use the one that is specified, and emit a warning if both are specified (and fallback to CustomFormat).
There was a problem hiding this comment.
Yes, that sounds perfect!
|
|
||
| fmt = t.toString(m_displayFormatString); | ||
| } else if (m_displayFormat == TrackTime::DisplayFormat::KILO_SECONDS) { | ||
| fmt = mixxx::Duration::formatKiloSeconds(dSecondsAbs); |
There was a problem hiding this comment.
Perhaps using a switch for the m_displayFormat might help with readability, although strictly equivalent?
|
Tbh I'm reluctant adding a widget that is not used in official skins. |
This PR adds a
WNumberDurationcontrol for displaying a control value given in seconds as a formatted time (e.g.hh:mm:ss).Although the
WNumberPoshas a similar purpose, it is tailored strictly for displaying the play position of a deck. TheWTimecontrol is also similar, but only displays the current time.The goal is to be able to display e.g. the remaining duration of the Auto DJ queue in the UI in a skin-controllable way, like so:
(Note: The above screenshot is from one of my development builds. Automatically calculating the remaining duration of the Auto DJ queue has its own gotchas, and so will be provided in a separate PR)