Refactor: Extract the CountsDuration table logic into PlaylistStatsDAO #13177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr7pt0gr4ph7
force-pushed
the
refactor-add-playliststatsdao
branch
from
6c3895b
to
70bb549
Compare
cr7pt0gr4ph7
force-pushed
the
refactor-add-playliststatsdao
branch
from
70bb549
to
fe863bc
Compare
cr7pt0gr4ph7
changed the title
|
Thank you for this PR! Please note that there is already #4846 which also does a playlist backend refactoring. |
|
@ronso0: Thanks for the heads up! I am not especially partial to the code in this PR, it was a byproduct of understanding the playlist duration calculation logic while working on #13183 (which, in the end, was implemented in a wholly different way instead), and none of my other code depends on it. So it's your call whether to merge this PR, or close it and wait for #4846 to finish - I am fine either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetlogFeatureandPlaylistFeature(as well asBasePlaylistFeature) contain nearly identical code for creating a summary table of the track number and total duration of all playlists (both history playlists and normal playlists).This PR unifies the code into a single
PlaylistStatsDAOclass, which has the added advantage of moving DB-layer code from the*Featureclasses to a more appropriate location.