New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove removed clang-tidy AnalyzeTemporaryDtors setting #13235

Merged

JoergAtGithub merged 1 commit into mixxxdj:2.4 from Swiftb0y:fix/remove-clang-tidy-analizetemporarydtors

May 28, 2024

Member

Swiftb0y commented May 14, 2024

My local builds always had this:

/home/swiftb0y/Sourcerepositories/mixxx/.clang-tidy:13:1: error: unknown key 'AnalyzeTemporaryDtors'
AnalyzeTemporaryDtors: false
^~~~~~~~~~~~~~~~~~~~~
Error parsing /home/swiftb0y/Sourcerepositories/mixxx/.clang-tidy: Invalid argument

Which seems to have been removed: https://stackoverflow.com/questions/63920634/what-is-the-meaning-of-the-analyzetemporarydtors-option-in-clang-tidy


          fix: remove removed clang-tidy AnalyzeTemporaryDtors setting

ffb9bf2

Member Author

Swiftb0y commented May 28, 2024

friendly ping ;)

Member

JoergAtGithub commented May 28, 2024

LGTM! Thank you!

JoergAtGithub merged commit ef8f24c into mixxxdj:2.4

14 checks passed

Swiftb0y deleted the fix/remove-clang-tidy-analizetemporarydtors branch

May 28, 2024 20:55

Member Author

Swiftb0y commented May 28, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment