use enum class for waveform overview type

[ronso0]

Follow-up for #13273

[ronso0]

I really don't understand those ControlFlag::NoAssertIfMissing flags above. Some controls are read when painting and there is no null check. Even if default controls return 0 there will a division by 0 at one place.
Should we remove those flags?

[daschuer]

I cannot imagine a valid reason that this is missing. Maybe a leftover from a refactoring?

[ronso0]

yeah, so I'll remove those.

[daschuer]

I cannot imagine a valid reason that this is missing. Maybe a leftover from a refactoring?

[Swiftb0y]

thank you, couple more nits

[Swiftb0y]

Suggested change

	int type = waveformOverviewComboBox->currentData().toInt();
	m_pConfig->setValue(kOverviewTypeCfgKey, type);
	m_pTypeControl->forceSet(type);
	QVariant comboboxData = waveformOverviewComboBox->currentData();
	DEBUG_ASSERT(comboboxData.canConvert<WOverview::Type>());
	auto type = comboboxData.value<WOverview::Type>();
	m_pConfig->setValue(kOverviewTypeCfgKey, type);
	m_pTypeControl->forceSet(static_cast<double>(type));

[Swiftb0y]

LGTM. There is still more cleanup possible in future PRs, but this is already an improvement. Thank you.

[Swiftb0y]

@daschuer do you want to take a look?
also @ronso0 do you have nerves to test out https://github.com/mixxxdj/mixxx/pull/13370/files#r1641522940 ?

[ronso0]

@Swiftb0y Looks good with the latest changes?

[Swiftb0y]

yes, the last remaining unresolved comment is #13370 (comment)

[Swiftb0y]

yes, the last remaining unresolved comment is #13370 (comment)

@ronso0 friendly ping ;)

[ronso0]

Isn't that fixed by the last fixup?
https://github.com/mixxxdj/mixxx/compare/91d9f6c724edf0540d8d595516f9cb8247ec1652..e8eea9fe25e505f4ddbefaa93741711d1224efda

[Swiftb0y]

I guess the link anchor doesn't work properly. I'm referring to this request 😅 :

[ronso0]

Oh-oh-kay, got it now 😬

[Swiftb0y]

Thank you. Waiting for CI.

[JoergAtGithub]

Lets merge this! Thank you!

[Swiftb0y]

sorry, forgot, thank you.