Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioUnitManager: Disable unavailable in-process instantiation on iOS #13383

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jun 16, 2024

In-process Audio Unit instantiation is unavailable on iOS, presumably due to stricter code execution policies, so we have to fall back to out-of-process instantiation.

@fwcd fwcd mentioned this pull request Jun 16, 2024
49 tasks
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer changed the base branch from main to 2.5 June 17, 2024 05:58
@daschuer
Copy link
Member

Since this is a fix in 2.5-beta code, please rebase to the 2.5 branch.

@fwcd fwcd force-pushed the disable-audiounit-in-process-ios branch from c463f33 to cddf731 Compare June 17, 2024 14:52
@fwcd
Copy link
Member Author

fwcd commented Jun 17, 2024

Done

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@daschuer daschuer merged commit c6a1993 into mixxxdj:2.5 Jun 17, 2024
13 checks passed
@fwcd fwcd deleted the disable-audiounit-in-process-ios branch June 17, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants