fix(engine-prime): build-failure #13397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, this only surfaced because of f031f51 |
daschuer
requested changes
Jun 24, 2024
|
right, but |
Swiftb0y
force-pushed
the
fix/engine-prime-build-failure
branch
from
5f4cf9a
to
04ac735
Compare
|
The virtual keyword is redundant. |
Explicitly instantiate default destructor in out-of-line (in .cpp) because destructing a `std::unique_ptr<Waveform>` needs `Waveform` to be complete at the point of destruction.
Swiftb0y
force-pushed
the
fix/engine-prime-build-failure
branch
from
04ac735
to
69bda20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly instantiate default destructor in out-of-line (in .cpp) because destructing a
std::unique_ptr<Waveform>needsWaveformto be complete at the point of destruction.