Don't return in JogWheelBasic on deck absent in option #13425
Conversation
| isPress: Button.prototype.isPress, | ||
| inValueScale: function(value) { | ||
| // default implementation for converting signed ints | ||
| return value < 0x40 ? value : value - (this.max + 1); | ||
| }, | ||
| inputWheel: function(_channel, _control, value, _status, _group) { | ||
| if (!this.hasDeckNumber) { | ||
| console.warn("bad deck number; ignoring inputWheel()"); |
There was a problem hiding this comment.
now this should actually return now, imo. same below.
| get hasDeckNumber() { | ||
| return Number.isInteger(this.deck) && this.deck > 0; | ||
| }, |
There was a problem hiding this comment.
we haven't used js getters until now. have you made sure this works? I'm not confident the Object merging logic handles getters and setters correctly.
There was a problem hiding this comment.
You're right. I had to use Object.defineProperties instead.
christophehenry
force-pushed
the
dont-return-on-no-deck-JogWheelBasic
branch
from
ff36f45
to
2356bb8
Compare
The current DN-S3700 controller I use retrieves its deck number from the deck's settings with a sysex message. Maybe there's another way but this is how it works right now. Plus, no other component requires an |
| get group() { | ||
| return self._deck; | ||
| }, |
There was a problem hiding this comment.
| get group() { | |
| return self._deck; | |
| }, | |
| get group() { | |
| return self._group; | |
| }, |
Thats a very valid argument. Thanks. |
| Component.prototype.connect.call(this); | ||
| this.deck = parseInt(script.channelRegEx.exec(this.group)[1]); | ||
| } | ||
| reset() {}, |
There was a problem hiding this comment.
This method is just there to allow cleaning when the deck has changed (for instance, stop a motorized jog).
|
So |
christophehenry
force-pushed
the
dont-return-on-no-deck-JogWheelBasic
branch
3 times, most recently
from
e94a366
to
38bbfc7
Compare
christophehenry
force-pushed
the
dont-return-on-no-deck-JogWheelBasic
branch
from
38bbfc7
to
7f739ac
Compare
|
I don't think so. The segfault is definitely weird. Can you collect a backtrace? |
This allows late binding of
JogWheelBasicusingComponentContainer.reconnectComponentsandDeck.setCurrentDeck.