fix: components.Pot producing wrong result on first value
#13463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in mixxxdj#4495 and reported as mixxxdj#11814
Swiftb0y
commented
Jul 11, 2024
Comment on lines
-484
to
486
| value = (value << 7) + (this._firstLSB ? this._firstLSB : 0); | ||
| this.input(channel, control, value, status, group); | ||
| this.input(channel, control, (value << 7) + (this._firstLSB ? this._firstLSB : 0), status, group); | ||
| } | ||
| this.MSB = value; |
There was a problem hiding this comment.
A quick word on the fix:
This only occurred when receiving the first value because this branch is only executed when receiving the first value. this.MSB is only supposed to contain the value of the most significant byte, but the branch erroneously set it contain the entire value. That meant if the MSB was received first everything would work out for the first message, however, when the LSB was received afterwards it would take the bogus MSB value set here resulting in huge bogus values. Once the second MSB was received, everything would work out as usual again. The fix now ensures that this.MSB gets the actual MSB value instead of the "pre-scaled" one that we use in the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #4495 and reported as #11814