Fix rename detect feature #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
reviewed
Nov 5, 2017
| @@ -1723,7 +1723,7 @@ bool TrackDAO::detectMovedTracks(QSet<TrackId>* pTracksMovedSetOld, | |||
| "INNER JOIN library ON track_locations.id=library.location " | |||
| "WHERE track_locations.location IN (%1) AND " | |||
| "filename=:filename AND " | |||
| "duration=:duration").arg( | |||
| "ABS(duration - :duration) < 1").arg( | |||
There was a problem hiding this comment.
Please insert a comment what the 1 means, and why it is required.
Is this a side effect from our repaired engine? https://bugs.launchpad.net/mixxx/+bug/1666275
Do we need to invalidate beatgrid and waveforms?
There was a problem hiding this comment.
Comment is in place. 😄
Basically, I believe this is a regression from #970, so I added tolerance of 1 second when searching for the (re)moved track.
Is this a side effect from our repaired engine? https://bugs.launchpad.net/mixxx/+bug/1666275
Do we need to invalidate beatgrid and waveforms?
I don't think so, I believe this is a different issue.
|
Thank you for the update. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://bugs.launchpad.net/mixxx/+bug/1650633 and possibly https://bugs.launchpad.net/mixxx/+bug/1711867