bugfix skin tango

[nopeppermint]

add missing right click functionality to hotcue buttons in sampler

[nopeppermint]

fixes https://bugs.launchpad.net/mixxx/+bug/1741504

[Be-ing]

LGTM thanks

[daschuer]

@nopeppermint:
I am unsure if you have already signed our contributor agreement.
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
can you do rectify this?
I will then add your name to the contributor list in the Mixxx about box.
Is it OK to use your full name from the agreement there?

[nopeppermint]

done, yes full name is ok

[ronso0]

I didn't implement right-click (remove hotCue) in samplers for a very simple reason:
once you deleted a HotCue (by accident) you have NO chance to re-set it on point with current sampler interface:

• no large waveform to see what you do
• no mapping/hotcues to move playposition

In which scenario "clearing Hotcue is a needed functionality also in Sampler"?
Samplers are not meant to be full decks due to aspects mentioned above

[Be-ing]

But how often do you accidentally right click on something?

[ronso0]

Although I use samplers rather rarely, it happened to me, that's why I removed the function.
Once it happens in a regular, stressy live mixing situation where you have to deal with trackpad or trackpoint only, it's a PITA to re-set..

[nopeppermint]

I didn't implement right-click (remove hotCue) in samplers ..

ok, I though that this was missing, because deck hotcue act as this as well as all hotcues on other skins..

if there is no right-click action then the Tooltip should be changed!
as Tooltip tells you, it will delete the hotcue on right-click ..