-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deere skin: Add most missing tooltips in attempt to fix https://bugs.… #1500
Changes from 18 commits
9d9a5bf
f384f81
99510f4
30aa6bd
38c6462
e9da243
d119889
cddabf1
b3c49b4
3ce7e68
cc7d8ae
9f10e47
4e53e11
303fe94
7f3b1d3
cde2bdf
8073569
9381ad9
3197e06
8f52fdf
2d06a30
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,19 +77,6 @@ | |
<Layout>horizontal</Layout> | ||
<ObjectName>ButtonGrid</ObjectName> | ||
<Children> | ||
|
||
<Template src="skin:left_display_2state_button.xml"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I plan to work a bit more on the samplers layout, but this must not be done in this PR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @esbrandt Will you take care of this before 2.1 release or should I? |
||
<SetVariable name="TooltipId">cueset</SetVariable> | ||
<SetVariable name="ObjectName">SamplerCueButton</SetVariable> | ||
<SetVariable name="MinimumSize"><Variable name="WideButtonMinimumSize"/></SetVariable> | ||
<SetVariable name="MaximumSize"><Variable name="WideButtonMaximumSize"/></SetVariable> | ||
<SetVariable name="SizePolicy"><Variable name="WideButtonSizePolicy"/></SetVariable> | ||
<SetVariable name="state_0_text">CUE</SetVariable> | ||
<SetVariable name="state_1_text">CUE</SetVariable> | ||
<SetVariable name="left_connection_control"><Variable name="group"/>,cue_set</SetVariable> | ||
<SetVariable name="display_connection_control"><Variable name="group"/>,cue_indicator</SetVariable> | ||
</Template> | ||
|
||
<Template src="skin:left_right_1state_button.xml"> | ||
<SetVariable name="TooltipId">beatsync_beatsync_tempo</SetVariable> | ||
<SetVariable name="ObjectName">BeatsyncButton</SetVariable> | ||
|
@@ -118,9 +105,8 @@ | |
<SetVariable name="state_0_unpressed">icon/ic_eject_48px.svg</SetVariable> | ||
<SetVariable name="left_connection_control"><Variable name="group"/>,eject</SetVariable> | ||
</Template> | ||
|
||
</Children> | ||
</WidgetGroup> | ||
</Children> | ||
</WidgetGroup> | ||
|
||
</Children> | ||
</WidgetGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restored to the initial, working state. Personally, i think the graphics should be removed as well for loops and CUE points, but there was no feedback yet in the original bug report https://bugs.launchpad.net/mixxx/+bug/1750210
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you replace them with? A letter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think the default rendering suits best - partly because of limitations in the subpixel rendering of the images.
For hotcues we allow to name hotcues (for now only in CUE tab of the tracks´ preferences). Adding an image will overwrite the hotcues´ label.
So + 1 for me here for default rendering.
For Loop-In, Loop-Out, and CUE points, i do think using images is not preferable for now, because of errors in the rendering of the images.
You can see it clearly when you have quantize enabled, and trying to exactly set a CUE image on a beat-grid. Even if your image is only 1px wide, it gets randomly placed left, right, or directly on the beat-grid line.
Skins that currently use marker images dodge this by making the vertical line off center, or 2+ pixel wide.