-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deere skin: Add most missing tooltips in attempt to fix https://bugs.… #1500
Changes from 1 commit
9d9a5bf
f384f81
99510f4
30aa6bd
38c6462
e9da243
d119889
cddabf1
b3c49b4
3ce7e68
cc7d8ae
9f10e47
4e53e11
303fe94
7f3b1d3
cde2bdf
8073569
9381ad9
3197e06
8f52fdf
2d06a30
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -248,6 +248,10 @@ QString PlaylistFeature::getRootViewHtml() const { | |
playlistsSummary4)); | ||
html.append("</td></tr>"); | ||
html.append(QString("<tr><td><a href=\"create\">%1</a>") | ||
//Colorize links in lighter blue, instead of QT default dark blue. | ||
//Links are still different from regular text, but readable on dark/light backgrounds. | ||
//https://bugs.launchpad.net/mixxx/+bug/1744816 | ||
html.append(QString("<a style=\"color:#0850D0;\" href=\"create\">%1</a>") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it works and looks like desired if the line is
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed with 83b515e There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
What is going on here, to which branch went this, and the other commits? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, sorry for being unclear. I made those commits to my fork of your 2.1 branch deere-crate-link-fix-fixed which you could just merge into yours. It contains:
|
||
.arg(createPlaylistLink)); | ||
html.append("</td></tr></table>"); | ||
return html; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is obsolete, isn't it?
<tr><td>
go to next line thenbuild fails due to missing ) and ;