Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deere skin: Add most missing tooltips in attempt to fix https://bugs.… #1500

Merged
merged 21 commits into from
Feb 25, 2018
Merged

Deere skin: Add most missing tooltips in attempt to fix https://bugs.… #1500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9d9a5bf
Deere skin: Add most missing tooltips in attempt to fix https://bugs.…
esbrandt Jan 27, 2018
f384f81
Merge remote-tracking branch 'upstream/2.1' into 2.1
esbrandt Feb 18, 2018
99510f4
Remove static images for Hotcues 1-4. They made sense when we had fix…
esbrandt Feb 18, 2018
30aa6bd
Deere: Replace controversial Hamburger icon with a gear icon (as alre…
esbrandt Feb 18, 2018
38c6462
Deere: Re-add option to load/save sampler banks to Skin settings > Sa…
esbrandt Feb 18, 2018
e9da243
Add tooltips for Sampler Bank controls. Use them in Tango and Deere
esbrandt Feb 20, 2018
d119889
Deere: Remove ``CUE`` button from samplers controls row. This was exc…
esbrandt Feb 20, 2018
cddabf1
Deere: Do not tread Hotcues 1-4 different than the rest. Previously, …
esbrandt Feb 20, 2018
b3c49b4
Deere: Remove infinite <MaximumSize> key in decks waveform overview …
esbrandt Feb 20, 2018
3ce7e68
Merge remote-tracking branch 'upstream/2.1' into 2.1
esbrandt Feb 20, 2018
cc7d8ae
Merge remote-tracking branch 'upstream/2.1' into 2.1
esbrandt Feb 21, 2018
9f10e47
Skins: Fix hard to read link color in CRATE and PLAYLIST pages of the…
esbrandt Feb 21, 2018
4e53e11
Revert "Skins: Fix hard to read link color in CRATE and PLAYLIST page…
esbrandt Feb 23, 2018
303fe94
Skins: Fix hard to read link color in CRATE and PLAYLIST pages of the…
esbrandt Feb 23, 2018
7f3b1d3
Removed waste text formatting using table cells in CRATE and PLAYLIST…
esbrandt Feb 23, 2018
cde2bdf
Removed waste text formatting using table cells in COMPUTER (BROWSE) …
esbrandt Feb 23, 2018
8073569
Tango: Add TooltipID for skin settings buttons in top bar, and skin s…
esbrandt Feb 23, 2018
9381ad9
Deere: Fix CUE point being invisible on main waveform, was accidental…
esbrandt Feb 23, 2018
3197e06
Add line break in 3rd paragraph of the long explanatory text in PLAYL…
esbrandt Feb 25, 2018
8f52fdf
Merge remote-tracking branch 'upstream/2.1' into 2.1
esbrandt Feb 25, 2018
2d06a30
Skins: Based on feedback, make hard to read link color in CRATE and P…
esbrandt Feb 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions res/skins/Deere/deck_visual_row.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,31 +68,31 @@
-->
<Mark>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restored to the initial, working state. Personally, i think the graphics should be removed as well for loops and CUE points, but there was no feedback yet in the original bug report https://bugs.launchpad.net/mixxx/+bug/1750210

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you replace them with? A letter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think the default rendering suits best - partly because of limitations in the subpixel rendering of the images.

  • For hotcues we allow to name hotcues (for now only in CUE tab of the tracks´ preferences). Adding an image will overwrite the hotcues´ label.
    So + 1 for me here for default rendering.

  • For Loop-In, Loop-Out, and CUE points, i do think using images is not preferable for now, because of errors in the rendering of the images.

    You can see it clearly when you have quantize enabled, and trying to exactly set a CUE image on a beat-grid. Even if your image is only 1px wide, it gets randomly placed left, right, or directly on the beat-grid line.

    Skins that currently use marker images dodge this by making the vertical line off center, or 2+ pixel wide.

<Control>hotcue_1_position</Control>
<Pixmap>image/marker_hotcue_1.png</Pixmap>
<Pixmap></Pixmap>
<Text>1</Text>
<Align>bottom</Align>
<Color>#00FF00</Color>
<TextColor>#FFFFFF</TextColor>
</Mark>
<Mark>
<Control>hotcue_2_position</Control>
<Pixmap>image/marker_hotcue_2.png</Pixmap>
<Pixmap></Pixmap>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this empty element be removed?

<Text>2</Text>
<Align>bottom</Align>
<Color>#00FF00</Color>
<TextColor>#FFFFFF</TextColor>
</Mark>
<Mark>
<Control>hotcue_3_position</Control>
<Pixmap>image/marker_hotcue_3.png</Pixmap>
<Pixmap></Pixmap>
<Text>3</Text>
<Align>bottom</Align>
<Color>#00FF00</Color>
<TextColor>#FFFFFF</TextColor>
</Mark>
<Mark>
<Control>hotcue_4_position</Control>
<Pixmap>image/marker_hotcue_4.png</Pixmap>
<Pixmap></Pixmap>
<Text>4</Text>
<Align>bottom</Align>
<Color>#00FF00</Color>
Expand Down
Binary file removed res/skins/Deere/image/marker_hotcue_1.png
View file
Open in desktop
Binary file not shown.
Binary file removed res/skins/Deere/image/marker_hotcue_2.png
View file
Open in desktop
Binary file not shown.
Binary file removed res/skins/Deere/image/marker_hotcue_3.png
View file
Open in desktop
Binary file not shown.
Binary file removed res/skins/Deere/image/marker_hotcue_4.png
View file
Open in desktop
Binary file not shown.