Add option to persist control values. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration. Remove ControlWidgetPropertyConnection loading and saving of control from config.
| // anywhere in Mixxx. | ||
| static ConfigObject<ConfigValue>* getUserConfig() { | ||
| return s_pUserConfig; | ||
| } |
There was a problem hiding this comment.
I think we can just use s_pUserConfig without a wrapping function,
| if (ok) { | ||
| value = configValue; | ||
| } | ||
| } |
There was a problem hiding this comment.
no need for a check,
value = pConfig->getValueString(m_key).toDouble();
this is fine, because toDouble returns 0.0 if conversion fails,
|
Thank you for you just in time fixes :-) |
|
Thanks for the review! |
rryan
added a commit
that referenced
this pull request
Jan 21, 2014
Add option to persist control values.
This was referenced Aug 22, 2022
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Resolves mixxxdj#156 without making downloading the latest version more complicated for regular users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Bug #1190797.