New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp1763007: Fix invocation args of pasuspender #1616

Merged

daschuer merged 2 commits into mixxxdj:2.1 from uklotzde:lp1763007_pasuspender_usage

Apr 17, 2018

Contributor

uklotzde commented Apr 16, 2018

https://bugs.launchpad.net/mixxx/+bug/1763007


          Fix invocation args of pasuspender

17f3ef6

Contributor

Be-ing commented Apr 16, 2018

Why is this change needed?

uklotzde added this to the 2.1.1 milestone

Contributor Author

uklotzde commented Apr 16, 2018 •

edited

Not really need until we add parameters to the invocation of Mixxx. Otherwise those command-line args would be interpreted by pasuspender: https://linux.die.net/man/1/pasuspender

Member

daschuer commented Apr 16, 2018

There are two more places.
In these cases without tailing "|| mixxx" should we add that as well?

Contributor Author

uklotzde commented Apr 16, 2018

Thanks for the hint. Yes, I will do this.


          Fix remaining invocations with of pasuspender

Member

daschuer commented Apr 17, 2018

LGTM, Thank you.

daschuer merged commit 4eb23c3 into mixxxdj:2.1

uklotzde deleted the lp1763007_pasuspender_usage branch

April 17, 2018 10:18

mixxxbot mentioned this pull request

Usage of pasuspender, missing -- #9233

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment